feat: Introduce jni catalog to support all catalogs #14264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
force-pushed
the
renjie/issue-13900
branch
from
db1b045 to
cc3ac77
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 4667 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 2049 | 1 | 2617 | 0 |
Click to see the invalid file list
- java/connector-node/risingwave-sink-iceberg/src/main/java/com/risingwave/connector/catalog/RESTObjectMapper.java
...risingwave-sink-iceberg/src/main/java/com/risingwave/connector/catalog/RESTObjectMapper.java
Show resolved
Hide resolved
BugenZhao
reviewed
Dec 29, 2023
liurenjie1024
force-pushed
the
renjie/issue-13900
branch
from
9b23cba to
72a236e
Compare
wenym1
reviewed
Dec 29, 2023
chenzl25
reviewed
Jan 2, 2024
liurenjie1024
force-pushed
the
renjie/issue-13900
branch
from
914b962 to
ea085fb
Compare
There was a problem hiding this comment.
license-eye has totally checked 4715 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 2059 | 3 | 2653 | 0 |
Click to see the invalid file list
- java/connector-node/risingwave-sink-iceberg/src/main/java/com/risingwave/connector/catalog/JniCatalogWrapper.java
- java/connector-node/risingwave-sink-iceberg/src/main/java/com/risingwave/connector/catalog/RESTObjectMapper.java
- src/connector/src/sink/iceberg/jni_catalog.rs
...isingwave-sink-iceberg/src/main/java/com/risingwave/connector/catalog/JniCatalogWrapper.java
Outdated
Show resolved
Hide resolved
liurenjie1024
force-pushed
the
renjie/issue-13900
branch
3 times, most recently
from
79ff68a to
1218e94
Compare
liurenjie1024
force-pushed
the
renjie/issue-13900
branch
from
5ff9cbc to
8c3f4b7
Compare
|
I think this pr is ready to merge. cc @chenzl25 @BugenZhao @xxchan @wenym1 |
liurenjie1024
added
the
user-facing-changes
liurenjie1024
force-pushed
the
renjie/issue-13900
branch
from
8c3f4b7 to
3081541
Compare
chenzl25
approved these changes
Jan 18, 2024
Comment on lines
+164
to
+175
| let jni_catalog_wrapper = env | ||
| .call_static_method( | ||
| "com/risingwave/connector/catalog/JniCatalogWrapper", | ||
| "create", | ||
| "(Ljava/lang/String;Ljava/lang/String;[Ljava/lang/String;)V", | ||
| &[ | ||
| (&env.new_string(name.to_string()).unwrap()).into(), | ||
| (&env.new_string(catalog_impl.to_string()).unwrap()).into(), | ||
| (&props).into(), | ||
| ], | ||
| ) | ||
| .unwrap(); |
There was a problem hiding this comment.
use call_static_method! marco in https://github.com/risingwavelabs/risingwave/blob/3081541a954d861da6ab73139d4d7a3b26adf2fe/src/jni_core/src/macros.rs instead?
BugenZhao
reviewed
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Close #13900.
We introduced a jni catalog to support all catalogs except rest/storage.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.